Fix missing options related to 'Tasks' #12507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12455
The following user options were added:
When selecting
Terminal-> Run Task...
+ Configure Task
entry when no tasks are configured (above contributed items)Show All Tasks...
entry at the bottom of the list of contributed tasks.multiroot
, sort by root then label)Go back ↩
option from second level picks.When selecting
Terminal-> Configure Tasks...
workspace
How to test
Prerequisites:
Activate
Auto Detect
preference forGulp
toon
From the:
Command palette -> type 'open user settings' -> click and then -> Navigate to (Extensions -> Gulp) and change 'Auto Detect' to 'on'
Activate
Auto Detect
preference forJake
toon
From the:
Command palette -> type 'open user settings' -> click and then -> Navigate to (Extensions -> Jake) and change 'Auto Detect' to 'on'
Use a clone of 'vscode' as the project to test
theia
with.vscode/settings.json
to delete the line:"gulp.autoDetect": "off"
.vscode/tasks.json
to remove the only "gulp" taskthis to prevent early activation of gulp.
Example test content:
Steps to test:
Terminal-> Run Task...
,+ Configure task
Using
theia
, open a project folder which does not have atasks.json
fileand has a
Jakefile.js
.Open the
Terminal-> Run Task...
option, verity the option+ Configure Task
is presentWhen selecting the option above, provided
jake
tasks shall be availableSelect a provided
jake
task and verify it populates thetasks.json
file with it.Terminal -> Run Task...
,Show All Tasks...
Using the same project as in the previous test
Terminal -> Run Task...
,Show All Tasks...
jake
tasks are available (alphabetically ordered)tasks.json
file.Terminal-> Run Task...
, select typegulp
,Go back ↩
gulp
tasks are listed and alphabetically orderedGo back ↩
and that it works to goback to display the previous level.
Repeat the steps 2 and 3 above using a multi-root workspace e.g. having
theia
andvscode
Test
Terminal-> Configure Tasks...
vscode
, select the optionTerminal-> Configure Tasks...
jake
,gulp
,npm
scope
and then bylabel
theia
andvscode
See test example video (
Run Task
):https://github.com/eclipse-theia/theia/assets/76971376/bab18c32-4557-4d8f-ae0b-36fe987bbb6f
See test example video (
Configure Tasks...
)https://github.com/eclipse-theia/theia/assets/76971376/d1340c58-b7c2-4618-a7f7-1bf8ca1fbec7
Review checklist
Reminder for reviewers