Make behaviour of "Open Workspace/Folder" consistent with VS Code #12537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsan09
requested changes
May 18, 2023
Fixes eclipse-theia#12534 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
12534_open_workspace_menu
branch
from
39b0d5b
to
ce27a10
Compare
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
12534_open_workspace_menu
branch
from
ce27a10
to
2deb37a
Compare
alvsan09
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The PR renames the "Open Workspace" file menu to "Open Workspace from File" and only allows selection of files in the resulting dialog on all platformas and browser/electron.
Fixes #12534
Contributed on behalf of STMicroelectronics
How to test
Use the "Open Workspace from File..." menu and make sure the behavior is as described above acrosss all platforms and electron/browser.
Review checklist
Reminder for reviewers