Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken link in @theia/keymaps package docs #12573

Merged
merged 1 commit into from
May 30, 2023
Merged

Update broken link in @theia/keymaps package docs #12573

merged 1 commit into from
May 30, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 28, 2023

What it does

Update the URL targeted by a reference link in the @theia/keymaps package's README.

How to test

  1. Click the "supported keys" link in the "Supported Keys" section of the current readme.
    🐛 The link leads to a 404 response page.
  2. Click the "supported keys" link in the "Supported Keys" of the version of the readme from this PR.
    🙂 The link is functional.
  3. Open the page for the previous URL as archived near the time of its addition to the readme (a6422c3):
    https://web.archive.org/web/20210925095416/https://eclipse-theia.github.io/theia/docs/next/modules/core.key-2.html
  4. Compare the archived page to the one targeted by the updated link from this PR.
    🙂 The updated link targets equivalent documentation content.

Review checklist

Reminder for reviewers

Changes to the module documentation structure caused the URL previously used in the link to 404.

Signed-off-by: Per Tillisch <accounts@perglass.com>
@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label May 29, 2023
@vince-fugnitto vince-fugnitto merged commit 9d65ca2 into eclipse-theia:master May 30, 2023
@vince-fugnitto vince-fugnitto added this to the 1.39.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants