-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[remote] Support download of native dependencies #12599
Closed
jonah-iden
wants to merge
14
commits into
eclipse-theia:master
from
jonah-iden:jiden/remote-feature-download-nativ-deps
Closed
[remote] Support download of native dependencies #12599
jonah-iden
wants to merge
14
commits into
eclipse-theia:master
from
jonah-iden:jiden/remote-feature-download-nativ-deps
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
smaller contribution improvements Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Added documentation for Publishing Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
changed the title
Jiden/remote feature download nativ deps
[remote] Support download of native dependencies
Jun 8, 2023
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
reviewed
Jun 9, 2023
packages/remote/src/node/native-dependency-download/native-dependency-download-service.ts
Outdated
Show resolved
Hide resolved
packages/remote/src/node/native-dependency-download/native-dependency-download-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
added
remote
issues related to the remote functionality
and removed
remote-ssh
issues related to the ssh remote functionality
labels
Jun 13, 2023
We've decided to integrate this change directly into #12618. I'll close this PR in favor of the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is a part of the Remote SSH feature #12390.
This PR is supposed to solve the problem of needing different native dependencies when copying the backend to a remote machine with a different OS or cpu-architecture.
As discussed in the theia-dev meeting on 6.6.23 these nativ dependencies should be included as assets in the respective theia release.
How to test
Its kind of hard to test since the rest of the feature is not yet integrated or used by anything.
The Github Actions workflow file is also deployed here for testing.
For testing the download contributions, it's probably easiest to create a small
BackendApplicationContribution
in theremote
package and execute theNativeDependencyDownloadService
downloadDependencies
inonStart()
in there like this:After that at least for rigrep (all other dependencies are not yet deployed so yet so it kind of download the website). Through debugging you could see that they are downloaded. or maybe writing the to the file system
Review checklist
Reminder for reviewers