Update ripgrep arguments for file search

[msujew]

What it does

Closes #12607

Updates our used arguments and child process spawn options to be aligned with vscode. In particular, the issue exhibited in #12607 was the result of the added stdio options property.

Removing the stdio field from the options fixed #12607 locally. Also updates the private methods to be protected.

How to test

1. Build the applications for different OS for Browser and Electron.
2. Perform file search, it should work as expected.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

LGTM 👍

• confirmed that searching with various options works as intended (ex: hidden files)
• CI successfully passes
• the options are aligned with vscode

[giraffesyo]

@msujew @vince-fugnitto
We noticed a performance regression after these ripgrep changes were introduced, and had to downgrade to the version just before this. This is on linux, inside a container. (Redhat UBI specifically). What we saw was many rg processes in the process list, which led us to try and figure out where they were coming from. We tracked it down to theia and then to this change. For now we're just sticking to v1.38.0 which doesn't have this issue.

[msujew]

@giraffesyo You can try to override the service in question in your adopter application and try to see which arguments/process spawn options lead to the issue. Since I'm unaware of anyone else having that issue, it might be a very specific set of environment+arguments+process spawn options that lead to this issue.

[giraffesyo]

@giraffesyo You can try to override the service in question in your adopter application and try to see which arguments/process spawn options lead to the issue. Since I'm unaware of anyone else having that issue, it might be a very specific set of environment+arguments+process spawn options that lead to this issue.

Awesome thanks for the very quick reply. That's a great idea, we will try these suggestions out!

[giraffesyo]

@msujew Our original assumptions of it being ripgrep were incorrect. There was also the @theia/git extension added, which depends on this package: https://github.com/Axosoft/find-git-repositories. That package seems to iterate through all directories in the workspace, to an infinite depth.

We have a mounted sftp using rclone, and the directory structure can be very large on the other side. When putting rclone into verbose mode it showed folders even 10 levels deep being hit before the entire container was OOM killed. After uninstalling the @theia/git extension all is well.

Worth noting, disabling the watchers with the setting

 {
"files.watcherExclude": {
    "**/**": true,
  }
}

also does the trick, but this has the unwanted side-effect that files created don't show up without refreshing the explorer pane.

[msujew]

Hey @giraffesyo, thanks for the update. Maybe it might make sense for you to use the vscode git plugins instead of @theia/git, which is being deprecated.