Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for windows execute command in terminal #12620

Merged

Conversation

jonah-iden
Copy link
Contributor

What it does

This fixes an issue that on windows commands where only pasted in the terminal and needed the user to press Enter again instead of being exeuted directly like in other Operating Systems

How to test

I tested it with the codeLLDB extension:

  1. Create a basic rust or c/c++ project
  2. create a codeLLDB debug configuration for launching the project.
  3. run the debug configuration.
  4. Debugging should start directly instead of displaying the terminal with the command pasted in there.

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@msujew msujew added terminal issues related to the terminal OS/Windows issues related to the Windows OS labels Jun 14, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, though I would like to see a minor refactoring regarding the use of EOL tokens, see below.

packages/terminal/src/browser/terminal-widget-impl.ts Outdated Show resolved Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Windows issues related to the Windows OS terminal issues related to the terminal
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants