Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/ux: fix flickering icons when resizing explorer #12629

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

vladarama
Copy link
Contributor

What it does

This PR closes #12615 by fixing the flickering of the toolbar icons when resizing the navigator. The issue was resolved by adding a new method called noPointerOnHover. This method temporarily disables pointer events on the explorer view when the mouse enters it which prevents the flickering behavior and leads to a better user experience.

Demo:
Fix Demo

How to test

  1. Open Theia application
  2. Go in the Explorer view and open a folder if none are open (File -> Open Folder)
  3. Click somewhere outside the Explorer view to make sure that it is not focused
  4. Resize the view and notice that the toolbar icons stay hidden until you stop resizing the view

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew added the ui/ux issues related to user interface / user experience label Jun 30, 2023
@msujew msujew merged commit 70ad9fd into eclipse-theia:master Jul 5, 2023
@vince-fugnitto vince-fugnitto added this to the 1.40.0 milestone Jul 27, 2023
@vladarama vladarama deleted the gh-12615-flicker branch July 31, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

navigator: flickering toolbar icons when resizing
3 participants