Quit Electron app when back end fails to start. Fixes #12769 #12778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2769 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
12769_quit_on_backend_problem
branch
from
3f8c4db
to
a99f85d
Compare
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
flexibrah
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When the back end process fails to start for some reason, the Electron process hangs with no Windows visible. This PR does an
app.quitin electron if the back end process fails to start.Fixes #12769
Contributed on behalf of STMicroelectronics
How to test
Start the electron version with a bogus parameter, for example
yarn electron start --log-level=Gurkensalat. Make sure you get back to the command prompt. Make sure the same command line works for correct cmd line argments.Review checklist
Reminder for reviewers