-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigator: handle middle-click behavior #12783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a bug when opening multiple editors using middle-click where we would incorrectly paste the clipboard into the editor (Linux):
- start the application
- confirm that content exists in the clipboard
- open multiple editors from the explorer using middle-click
- confirm the bug exists where clipboard content is being pasted into previous editors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the changes work as expected 👍
- middle-click in the explorer, and other trees (ex: siw) works as expected
- middle-clicking collapsible nodes correctly expands/collapses nodes
- the auto-scroll behavior was fixed (confirmed on Firefox)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me as well 👍
I'll merge, we can catch any potential regressions throughout the month if necessary. |
What it does
Fixes: #12762
Fixes: #12788
This PR handles the middle-click button behavior in various tree-widgets, such as the
explorer
,search-in-workspace
,references
... Like in VS Code, selecting a file using the middle-button will open that file as an open-editor instead of simply selecting it. This achieves the same functionality as double-clicking on a file, but it is faster.Demo:
How to test
Explorer
/Search-in-workspace
/SCM
/... viewsReview checklist
Reminder for reviewers