Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: can rebind the monaco editor command handler #12785

Conversation

kittaakos
Copy link
Contributor

What it does

It binds the monaco editor command handler to self so that a downstream project can customize it. Currently, it is not possible:

Error: Could not unbind serviceIdentifier: MonacoEditorCommandHandlers
    at __webpack_modules__.../node_modules/inversify/lib/container/container.js.Container.unbind (container.ts:170:19)
    at __webpack_modules__.../node_modules/inversify/lib/container/container.js.Container.rebind (container.ts:161:14)
    at container.ts:310:41
    at ContainerModule.registry (arduino-ide-frontend-module.ts:1052:3)
    at __webpack_modules__.../node_modules/inversify/lib/container/container.js.Container.load (container.ts:110:27)
    at index.js:113:1

How to test

Theia works, and basic editor commands such as find, select all, undo, and redo functional.

Review checklist

Reminder for reviewers

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@vince-fugnitto vince-fugnitto added monaco issues related to monaco extensibility issues to simplify ability to extend Theia labels Jul 31, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JonasHelming
Copy link
Contributor

@kittaakos Do you want to merge?

@msujew
Copy link
Member

msujew commented Aug 8, 2023

@JonasHelming Akos cannot merge, as he isn't a team member. @vince-fugnitto Needs to do that.

@vince-fugnitto vince-fugnitto merged commit f00450f into eclipse-theia:master Aug 8, 2023
6 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility issues to simplify ability to extend Theia monaco issues related to monaco
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants