Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for empty navigator #12795

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 2, 2023

What it does

Removes a long-standing TODO about localizing the message for empty multi-root workspaces.

How to test

  1. Create an empty workspace file:
{
  "folders": [],
  "settings": {}
}
  1. Open the workspace.
  2. Observe that the message in the widget is correctly localized

Review checklist

Reminder for reviewers

@msujew msujew added navigator issues related to the navigator/explorer localization issues related to localization/internalization/nls labels Aug 2, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msujew I believe the use-case might be incorrect, the renderEmptyMultiRootWorkspace method applies when a multi-root workspace with no roots is opened:

test.theia-workspace

{
  "folders": [
  ],
  "settings": {}
}

In such a case there is a bug with the implementation:

image

@msujew
Copy link
Member Author

msujew commented Aug 2, 2023

@vince-fugnitto Thanks for the hint :)

I've updated the changes to be a bit less ambitious and updated the testing steps as well.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • confirmed the rendering is correct
  • confirmed the content is properly localized

@msujew msujew merged commit ff9eb11 into master Aug 4, 2023
6 checks passed
@msujew msujew deleted the msujew/localize-empty-workspace branch August 4, 2023 13:44
@github-actions github-actions bot added this to the 1.41.0 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls navigator issues related to the navigator/explorer
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants