Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: refactor manage sidebar menu #12803

Merged
merged 1 commit into from
Oct 10, 2023
Merged

core: refactor manage sidebar menu #12803

merged 1 commit into from
Oct 10, 2023

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Aug 7, 2023 •
edited
Loading

What it does

The pull-request refactors the sidebar menu (bottom settings-cog icon) to more closely align with VS Code.
The menu was refactored to manage and contains additional menu items in a more clear ordering.

Before:

image

After:

image

How to test

  1. start the application
  2. confirm that the sidebar menu works as expected, items are properly organized and work

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Aug 7, 2023
msujew
msujew approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Vince! Don't forget to update the breaking changes for 1.42.0 after rebasing :)

packages/core/src/browser/common-frontend-contribution.ts Outdated Show resolved Hide resolved
@msujew
Copy link
Member

msujew commented Sep 25, 2023

@vince-fugnitto Do you plan to merge this before the release?

@vince-fugnitto vince-fugnitto force-pushed the vf/manage-sidebar branch 2 times, most recently from d7dafe9 to a3e7f1a Compare September 29, 2023 16:13
@vince-fugnitto
core: refactor manage sidebar menu
087e984 
The commit refactors the `manage` sidebar menu (previously settings) to
the same organization present in vscode with similar commands.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@JonasHelming
Copy link
Contributor

@vince-fugnitto Can this be merged?

@vince-fugnitto vince-fugnitto merged commit e32a0f3 into master Oct 10, 2023
14 checks passed
@github-actions github-actions bot added this to the 1.43.0 milestone Oct 10, 2023
@vince-fugnitto vince-fugnitto deleted the vf/manage-sidebar branch October 10, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
ui/ux issues related to user interface / user experience
Projects
PR Backlog
Archived in project
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vince-fugnitto @msujew @JonasHelming