Retire context keyword from keybindings
#12830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
keybindings
FernandoAscencio
force-pushed
the
fa/RetireKeybindingContext
branch
2 times, most recently
from
2a1cc4b
to
be4bc27
Compare
The method did not properly set the visibility state of notifications. Thus, the context keys were not properly updated. Signed-Off-By: Fernando Ascencio <fernando.ascencio.cama@ericsson.com>
Retiring the use of `context` in keybindings Signed-Off-By: Fernando Ascencio <fernando.ascencio.cama@ericsson.com>
- `Blame Keybinding context` deletion - `Terminal Keybinding context` deletion - `Console Keybinding Context` deletion - `Debug Keybinding Context` deletion - `Editor Keybinding Context` deletion - `Notification Keybinding Contribution` Deletetion - `Navigator Keybinding Context` deletion Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio
force-pushed
the
fa/RetireKeybindingContext
branch
from
be4bc27
to
06f8f36
Compare
msujew
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Close #12657
Signed-Off-By: FernandoAscencio fernando.ascencio.cama@ericsson.com
How to test
The following keybindings should be working:
ctrl+awhile focused on the content of the debug consoledenter,upArrow,downArrowwhile in the input box of the debug console.shit+f5,shift+ctrl+f5,f10,f11,shift+f11,f5,f6, while in a debug session.f9,shift+f9while in a text editor open.enterwhile focused in the input text box of the breakpoint editor widget.escwhile a breakpoint editor widget is open and focused in said widget or the text editor that contains it.alt+bwhile in a text editor and the document is blameable.escwhile the text editor is displaying blame comments.escwhen notifications (toast or ) are activef2,ctrl+i, anddel(Win/Lnx) orctrl+del(Mac) when in the explorer or file navigator.escwhen the find widget is active in a terminal window.Review checklist
Reminder for reviewers