Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inline breakpoint appears when deleting the last line code [#10874] #12832

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

vatsal-uppal-1997
Copy link
Contributor

What it does

Fixes: #10874

This commit resolves the issue where inline breakpoints were getting added when removing the last line of code in a particular line.

How to test

Follow the steps as mentioned in #10874

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Aug 15, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

  • I can no longer reproduce the incorrectly set column-breakpoint with this change
  • No regression in the actual debugging process found

@msujew msujew merged commit 6843880 into eclipse-theia:master Sep 12, 2023
6 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Inline breakpoint appears when deleting the last line code
3 participants