Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for WebviewPanelSerializer not working in Theia #12854

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Fix for WebviewPanelSerializer not working in Theia #12854

merged 4 commits into from
Aug 24, 2023

Conversation

vatsal-uppal-1997
Copy link
Contributor

What it does

Fixes #12834

For a detailed root cause analysis, refer to this comment

How to test

  1. Clone the test repository from issue WebviewPanelSerializer not working in Theia #12834
  2. cd into the "myext" folder and create a packaged vscode plugin by running the "vsce package" command
  3. Copy the packaged vsix file into this issue's git repository and paste it into the "plugins" folder
  4. Run the application and see if you're able to reproduce issue WebviewPanelSerializer not working in Theia #12834

Review checklist

Reminder for reviewers

@vatsal-uppal-1997 vatsal-uppal-1997 mentioned this pull request Aug 23, 2023
Closed
@jfaltermeier jfaltermeier self-requested a review August 24, 2023 08:53
jfaltermeier
jfaltermeier approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, lgtm. I've tested with the reproducer on the ticket and it is working for me.

@jfaltermeier jfaltermeier merged commit 0184f16 into eclipse-theia:master Aug 24, 2023
6 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility webviews issues related to webviews labels Aug 31, 2023
This was referenced Nov 27, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaltermeier jfaltermeier jfaltermeier approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
PR Backlog
Archived in project
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.

WebviewPanelSerializer not working in Theia
3 participants
@vatsal-uppal-1997 @jfaltermeier @vince-fugnitto