Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Stub TestController invalidateTestResults #12944

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

rschnekenbu
Copy link
Contributor

What it does

Stub new method on TestController for 1.81 vs code compat

This can push the compatibility towards 1.81 until Test API implementation has been reviewed and merged (see #12935)

Fixes #12884

Contributed on behalf of ST Microelectronics

How to test

Not much, as this is a stubbed API.

Results of the API report:
invalidateTestResults_stubbed

Follow-ups

This will be replaced by a concrete (empty) implementation when PR #12935 is merged

Review checklist

Reminder for reviewers

- add missing API for TestController as a stub

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm

@msujew msujew added the vscode issues related to VSCode compatibility label Sep 27, 2023
@rschnekenbu
Copy link
Contributor Author

This Pull Request has been approved, can we merge this one please? I can't do it by myself, not being a committer.

@JonasHelming JonasHelming merged commit 4564a4b into eclipse-theia:master Sep 27, 2023
10 of 13 checks passed
@rschnekenbu rschnekenbu deleted the issues/12884 branch September 27, 2023 13:47
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Support TestController invalidateTestResults API
5 participants