Make tree widget indentation configurable #13179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraBuzila
force-pushed
the
configure-tree-indentation
branch
2 times, most recently
from
cb08a95 to
4f07454
Compare
msujew
reviewed
Dec 19, 2023
There was a problem hiding this comment.
I don't think this change is working as expected/as it should.
- Indent pinning doesn't work, see below.
- Increasing the indent also increases the indent of the root tree items. This isn't the case in vscode. In vscode, the root tree items always stay in the same spot. This indicates that we still need the
leftPaddingproperty that tells us how much the root tree items are padded, while adding aindentPaddingthat tells us how much each indented tree item needs to be padded.
By fixing 2. you should also be able to fix 1. as a drive by.
packages/navigator/src/browser/open-editors-widget/navigator-open-editors-widget.tsx
Outdated
Show resolved
Hide resolved
AlexandraBuzila
force-pushed
the
configure-tree-indentation
branch
from
4f07454 to
38ae7d5
Compare
|
Thank you for the review, @msujew I updated the code and restored the |
AlexandraBuzila
force-pushed
the
configure-tree-indentation
branch
from
38ae7d5 to
fe913b7
Compare
msujew
reviewed
Jan 16, 2024
msujew
reviewed
Jan 16, 2024
Make the indentation of the tree widget configurable via preference. Contributed on behalf of STMicroelectronics Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
AlexandraBuzila
force-pushed
the
configure-tree-indentation
branch
from
fe913b7 to
588fedb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Make the indentation of the tree widget configurable via preference.
Contributed on behalf of STMicroelectronics
How to test
workbench.tree.indentWorkbench › Tree: Indentpreference and notice how the indentation of the tree widget, e.g. in the workspace navigator view, changes accordinglyReview checklist
Reminder for reviewers