Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we do not spam the log in the RpcProxyFactory #13191

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Ensure we do not spam the log in the RpcProxyFactory #13191

merged 2 commits into from
Jan 17, 2024

Conversation

martin-fleck-at
Copy link
Contributor

What it does

Fixes #13189

How to test

  • Produce an error in any Rpc-based communication, e.g., Theia frontend-backend
  • Watch the error being logged in the console even if you catch it

Review checklist

Reminder for reviewers

@martin-fleck-at martin-fleck-at force-pushed the issues/13189 branch 2 times, most recently from 3551882 to 2c79aed Compare January 16, 2024 17:12
tortmayr
tortmayr approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martin-fleck-at martin-fleck-at merged commit f7b1a78 into master Jan 17, 2024
14 checks passed
@martin-fleck-at martin-fleck-at deleted the issues/13189 branch January 17, 2024 12:48
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.

RpcProxyFactory always produced console error log
2 participants
@martin-fleck-at @tortmayr