Allow to rebind messaging services in preload #13199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13094
When trying to rebind the messaging services in the preload step, you were only able to bind them for a child container of the original container. That eventually led to multiple messaging services being created, which leads to unexpected issues, such as multiple websocket connections (where only one is actually needed).
This change binds the preload services directly on the global frontend container. This way, adopters can rebind messaging services already in the preload stage, preventing multiple instances of those services from appearing.
How to test
You will need to rebind the messaging services. Create a new module and perform the binding like this:
Afterwards put this in an additional
frontendPreload
entry in the package.json, build and start the browser app. At frontend startup, the logging above should be printed only once and the frontend preload should perform without errors.Review checklist
Reminder for reviewers