Set initial size and position of secondary windows #13201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. sized the same as the original widget that we are extracting into it's own windows and position at the same place, with an offset. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
…om/eclipse-theia/theia into secondary-window
…om/eclipse-theia/theia into secondary-window
This prototype implements the initial size and positions of secondary windows. It also adds a preference, called `Secondary Window Placement` allowing the user to choose the placement of the secondary windows between: - originalSize: same size as the widget. - splitScreen: half the size of the Theia application, positioned to the side. - fullScreen: the secondary window will take up the full screen. Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
…into secondary-window
This commit implements the correct values for the initial size and position of secondary windows. Signed-off-by <vlad.arama@ericsson.com>
…into secondary-window
Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
…into secondary-window
packages/core/src/browser/window/default-secondary-window-service.ts
Outdated
Show resolved
Hide resolved
This commit does the following changes: - rename `halfSize` to `halfWidth` - set `alwaysOnTop` to false by default Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
vladarama
commented
Dec 21, 2023
There was a problem hiding this comment.
@jfaltermeier
Thanks for the review,
I have addressed your comments and the implementation should now match the user's expectations 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR implements the initial size and positions of secondary windows. It adds a preference called
Secondary Window Placementallowing the user to choose the placement of the secondary windows between:originalSize(default): same size as the original widget.halfSize: half the size of the running Theia applicationfullSize: the same size as the running Theia application.In addition, another preference (
alwaysOnTop) is introduced that allows the user to decide if they want the secondary window to always stay above all other windows, including those of different applications.How to test
drawioextension.Secondary Window Placementpreference.test.drawiofile or create a new terminal and open it as a secondary window.Follow-ups
The secondary window popup might not line up perfectly with the original widget since the API used to get the window dimensions has inconsistencies across different browsers and operating systems.
Review checklist
Reminder for reviewers