Fix inputbox onTriggerButton() event #13207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Ensure that the clicked button is correctly forwarded to event handlers when using
InputBox.onDidTriggerButton
(Plugin API).The interface definition of
QuickInputButtonHandle
expects anindex
property but monaco actually calls the propertyhandle
Fixes #13077
Contributed on behalf of ST Microelectronics
How to test
Create a simple plugin that opens a QuickInputBox with two buttons and log the
onDidTriggerButton
event.On master the event is always undefined. With this change the clicked button is correctly forwarded to the event handlers.
e.g:
You can also use this example plugin:
quickpick-0.0.1.zip
Follow-ups
Review checklist
Reminder for reviewers