Pass argument to webview context menu action #13228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When executing a command via the context menu of a webview, vscode passes the context of the clicked html node to the command as an argument.
This PR aligns Theia's implementation of the webview context menu with vscode.
How to test
A small test extension can be found here.
The repo also contains a vsix file to download directly.
Go to the explorer tab, expand the Webview Test View webview. This contains two elements opening the context menu on each should return a different command because of their given context through the data-vscode-context property. Executing the command should now also include the stringified data from the
vscode-data-context
html-attributeReview checklist
Reminder for reviewers