-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation on passing objects across RPC #13238
Conversation
b764e13
to
5e4d56a
Compare
5e4d56a
to
f43b452
Compare
@tsmaeder @jcortell68 I pushed an updated version of the documentation. It would be really great if you could have a very quick read through it to see if there is still something unclear or missing from your point of view. Thank you! |
The new text/description looks perfect to me. Thank you! I know this was a bit of a pain to pin down, but if it was difficult for us to do that, imagine the Theia newbie working on API trying to figure that out on his own. This will help a lot. |
@jcortell68 @tsmaeder If the documentation looks good to you, please approve the PR so I can merge it, thank you! |
Ah. Didn't think my approval was technically needed since I'm not a maintainer/committer in the project. Maybe Theia works differently than other open source projects I've worked with. Done. |
@jcortell68 It is technically not needed but I like to get a clean state on the PR before merging it, also for history-preserving reasons ;-) |
What it does
Improves documentation.
Fixes #13224
How to test
Follow-ups
Review checklist
Reminder for reviewers