SelectComponent does not render droplist correctly in dialog (#12895) #13261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Jan 11, 2024
examples/api-samples/src/browser/menu/sample-menu-contribution.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
|
@msujew |
|
@dhuebner You need to adjust the references to the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #12895
How to test
I've added a new "Sample React Dialog" as there were any samples that are using react. Open it using the "Sample React Dialog" command.
Before:
After:
Follow-ups
I can remove the sample dialog again if you don't want to have it.
Also, I don't know why, but the *.css file was auto formatted with a probably different rules as it was initially created.