Address gap in coding guideliness. #13278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guidelines discourage the use of @multiInject and lists the benefits of ContributionProvider, but neglects to mention the filtering feature of that utility.
martin-fleck-at
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Change looks good to me and I like the reference to the filter capabilities as it is very powerful and not that easy to discover. Thank you @jcortell68!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guidelines discourage the use of @multiInject and lists the benefits of ContributionProvider, but neglects to mention the filtering feature of that utility.
Addresses #13277
What it does
Makes a simple enhancement to the coding guidelines.
How to test
Read the enhancement.
Follow-ups
None
Review checklist
Reminder for reviewers