Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core localizations for electron builds #13331

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 30, 2024

What it does

Closes #13330

Modifies the general ../../browser import to be more specific. The general import tries to import all sorts of code that requires the localizations.

How to test

  1. Start the electron application and install a localization.
  2. Confirm that the menus are all correctly localized.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Jan 30, 2024
Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msujew msujew merged commit b15b639 into master Jan 30, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.47.0 milestone Jan 30, 2024
@msujew msujew deleted the msujew/fix-electron-localization branch January 30, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
2 participants