Add prefix to contributed view container ids #13362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds the prefix
workbench.view.extension.
to the id of view containers contributed by plugins. As the id of the view container now contains dots, it can no longer be used as a css selector, so we now generate a sequential id.Fixes #13249
Contributed on behalf of STMicroelectronics
How to test
I use the tree-view-sample from https://github.com/microsoft/vscode-extension-samples/. The example contributes a view called "Node Dependencies" in a container called "Package Explorer" plus it adds a bunch of views to the standard "Explorer" view container. Make sure you can open/close/reopen the "Package Explorer" view and that all the contributed views are functional, including showing the proper icons.
Follow-ups
Review checklist
Reminder for reviewers