Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-ext-vscode: ignore vsix files in local-plugins dir #13435

Merged
merged 1 commit into from
Apr 24, 2024
Merged

plugin-ext-vscode: ignore vsix files in local-plugins dir #13435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/plugin-ext/src/main/node/plugin-deployer-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,20 @@ export class PluginDeployerImpl implements PluginDeployer {
}

protected async resolveAndHandle(id: string, type: PluginType, options?: PluginDeployOptions): Promise<PluginDeployerEntry[]> {
const entries = await this.resolvePlugin(id, type, options);
await this.applyFileHandlers(entries);
let entries = await this.resolvePlugin(id, type, options);
if (type === PluginType.User) {
await this.applyFileHandlers(entries);
} else {
const filteredEntries: PluginDeployerEntry[] = [];
for (const entry of entries) {
if (await entry.isFile()) {
this.logger.warn(`Only user plugins will be handled by file handlers, please unpack the plugin '${entry.id()}' manually.`);
} else {
filteredEntries.push(entry);
}
}
entries = filteredEntries;
}
await this.applyDirectoryFileHandlers(entries);
return entries;
}
Expand Down
Loading