-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed context keys for notebook editor context #13448
Fixed context keys for notebook editor context #13448
Conversation
this makes commands from jupyter available Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/notebook/src/browser/service/notebook-context-manager.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/service/notebook-kernel-service.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/service/notebook-kernel-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
How did you reproduce it in the app? |
@jonah-iden I enabled the TypeScript Reference Lens setting in the app and opened a |
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
should be fixed now |
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
…rk with the previous solution) Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What it does
This fixes the setting of context keys for editor level context keys. Only implements some of the keys currently (see
notebook-context-manager.ts
).This makes jupyter commands like
Export As
orRestart Kernel
available in the notebook editor toolbarHow to test
Follow-ups
Implement the outline view for notebooks including the
outline.focus
command so that theShow Table of Contents
command works as wellReview checklist
Reminder for reviewers