Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty plugin view containers from user #13581

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 9, 2024

What it does

For some reason, the jupyter notebook extension registers an empty view container. See here. Theia shows the empty container in the Views menu and even allows the user to open it (even though it is completely empty):

image

However, this doesn't matter in vscode, as empty view containers (i.e. view containers which never have a view registered to them) are just not visible to the user in any way.

This change aligns our UX to vscode and only registers the appropriate commands/menu entries once a view has been added to the view container.

How to test

  1. Install the Jupyter plugin
  2. Only one Jupyter entry should be visible in the Views menu
  3. Only one View: Toggle Jupyter command should be visible
  4. All other plugin view containers should work as expected

Review checklist

Reminder for reviewers

@msujew msujew added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility ui/ux issues related to user interface / user experience labels Apr 9, 2024
@msujew msujew requested a review from jonah-iden April 10, 2024 08:22
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as described and looks good to me

@jonah-iden jonah-iden merged commit 32f393a into master Apr 10, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 10, 2024
@msujew msujew deleted the msujew/hide-empty-view-container branch April 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system ui/ux issues related to user interface / user experience vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants