Hide empty plugin view containers from user #13581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
For some reason, the jupyter notebook extension registers an empty view container. See here. Theia shows the empty container in the
Views
menu and even allows the user to open it (even though it is completely empty):However, this doesn't matter in vscode, as empty view containers (i.e. view containers which never have a view registered to them) are just not visible to the user in any way.
This change aligns our UX to vscode and only registers the appropriate commands/menu entries once a view has been added to the view container.
How to test
Jupyter
entry should be visible in theViews
menuView: Toggle Jupyter
command should be visibleReview checklist
Reminder for reviewers