-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include build into publish GH pages workflow #13822
Conversation
fixed #13821 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@jfaltermeier Could you have a look at this please? |
I tried running the workflow here: https://github.com/eclipse-theia/theia/actions/runs/9742697234 Unfortunately there are failures |
* remove "needs: build" from Publish GitHub Pages job
* update typedoc and typedoc plugins * fix error in typedocs * increase memory
Publishing gh-pages seems to work with this branch: https://github.com/eclipse-theia/theia/tree/gh-pages. I’ve also opened three tickets for the license check: |
IP tickets are approved. |
@jfaltermeier Do we even need this PR anymore then? |
Yes we need it, the run was triggered from this branch. |
Can you apporve it then ? :-) |
I’ve added a few commits to this branch, so I think it’s better if someone else reviews the changes. |
What does this PR do? Does it fix the workflow that did not work beforehand? As far as i can tell the title and description of the PR are not up to date anymore, right? The changes do not include the build into the workflow as far as i can see. |
Yes, that’s correct, the description is outdated. I’ll update it. The initial issue was the Additionally, I had to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for the explanation
fixed #13821
What it does
needs: build
dependency in the workflowtypedoc
to be compatible with the current TypeScript versionHow to test
Review checklist
Reminder for reviewers