Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include build into publish GH pages workflow #13822

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Include build into publish GH pages workflow #13822

merged 7 commits into from
Dec 16, 2024

Conversation

JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Jun 18, 2024

fixed #13821

What it does

  • Remove needs: build dependency in the workflow
  • Update typedoc to be compatible with the current TypeScript version
  • fix some typedocs that were causing errors during generation.

How to test

Review checklist

Reminder for reviewers

fixed #13821

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming marked this pull request as draft June 18, 2024 11:16
@JonasHelming
Copy link
Contributor Author

@jfaltermeier Could you have a look at this please?

@jfaltermeier
Copy link
Contributor

I tried running the workflow here: https://github.com/eclipse-theia/theia/actions/runs/9742697234 Unfortunately there are failures

@jfaltermeier
Copy link
Contributor

jfaltermeier commented Dec 11, 2024

@jfaltermeier
Copy link
Contributor

IP tickets are approved.
Typedoc is here: https://eclipse-theia.github.io/theia/docs/next/index.html

@jfaltermeier jfaltermeier removed their request for review December 11, 2024 14:42
@jfaltermeier jfaltermeier marked this pull request as ready for review December 11, 2024 14:42
@JonasHelming
Copy link
Contributor Author

@jfaltermeier Do we even need this PR anymore then?

@jfaltermeier
Copy link
Contributor

Yes we need it, the run was triggered from this branch.

@JonasHelming
Copy link
Contributor Author

Can you apporve it then ? :-)

@jfaltermeier
Copy link
Contributor

I’ve added a few commits to this branch, so I think it’s better if someone else reviews the changes.

@sgraband
Copy link
Contributor

What does this PR do? Does it fix the workflow that did not work beforehand? As far as i can tell the title and description of the PR are not up to date anymore, right? The changes do not include the build into the workflow as far as i can see.

@jfaltermeier
Copy link
Contributor

Yes, that’s correct, the description is outdated. I’ll update it.

The initial issue was the needs: build dependency in the workflow, but the build step no longer existed after a refactoring. I believe the build now happens via yarn --skip-integrity-check --network-timeout 100000 in the Pre-npm-Publish step.

Additionally, I had to update typedoc to be compatible with the current TypeScript version and fix some typedocs that were causing errors during generation.

Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the explanation

@jfaltermeier jfaltermeier merged commit 4e3b183 into master Dec 16, 2024
12 checks passed
@jfaltermeier jfaltermeier deleted the GH-13821 branch December 16, 2024 12:52
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix build to publish TypeDoc
3 participants