Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cell height when updating output #14621

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This fixes an issue that the cell height was not updated in the output webview after rendering an output. This lead to overlap of output with other cells

How to test

  • Open a notebook
  • create a few cells and execute them
  • validate that changing the cell height (by for example ading a line) the distance between cell and output does not change anymore.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@dhuebner dhuebner self-assigned this Dec 13, 2024
@dhuebner dhuebner self-requested a review December 13, 2024 10:00
@dhuebner dhuebner removed their assignment Dec 13, 2024
Copy link
Member

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!
The bogus behavior is no longer reproducible.

@jonah-iden jonah-iden merged commit 35d458a into master Dec 13, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/fix-cell-height-when-output-rendered branch December 13, 2024 10:02
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants