Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'required' to tool call parameters #14673

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Add 'required' to tool call parameters #14673

merged 1 commit into from
Dec 30, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #14672

What it does

  • Adds 'required' to the schema for tool parameters
  • Defines required for all existing functions with parameters
  • Retrieves 'required' when converting tool functions from MCP servers

How to test

Try the existing tool functions and one MCP server.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming requested review from sdirix and planger and removed request for sdirix December 24, 2024 23:19
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@JonasHelming JonasHelming merged commit e27e4d4 into master Dec 30, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Theia AI] Tool function parameter defintion shall support 'required'
2 participants