stub TerminalCompletionProvider proposed API #14719
Open
+184
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes eclipse-theia#14604 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/14604
branch
from
d230207 to
d08da43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Contributes the stub to the proposed API terminalCompletionProvider, used by the builtin extension terminal-suggest.
fixes #14604
How to test
Rather than using terminal-suggest builtin, this sample extension can be used to test the stub:
This does nothing as the API is stubbed, but this should trigger no warning or errors when activating the extension.
Follow-ups
Implement the API. Follow up ticket added to the list of APIs to be implemented. (Issue 12010)
Breaking changes
Attribution
contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers