Update monaco-editor-core to 1.96.3 #14737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14726 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
Converting to "draft" status while waiting for https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18700 |
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18700 has been approved. |
|
@tsmaeder I can take a look today in the evening |
sdirix
reviewed
Jan 28, 2025
There was a problem hiding this comment.
I performed the following tests:
- QuickPick
- Open
- Select
- Escape
- Text Editor
- Open without extensions (i.e. no syntax highlighting etc.)
- With extensions
- Extract to second window
- Switching theme
- Debugging
- Text Editor Typescript
- Syntax Highlighting
- Error/Warning markers
- Refactor Actions
- Hover
- Autocomplete
- Inline suggestions (AI)
- Drag&Drop of code
- Preferences Editor
- Editing preferences
- JSON view
- Both at same time
- Output channel
- Diff editor
- Open a diff
- Accepting/Reverting a change
- Debug
- Setting, Editing and Hitting break points
I tested both in Browser and Electron
The only behavior finding which I found when testing the apps:
Revert popup
In the diff editor, the reverting a change popup looks broken:
In the current master it looks fine:
packages/editor/src/browser/editor-language-quick-pick-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #14726
Contributed on behalf of STMicroelectronics
How to test
This needs a general test of functionality in particular of all editor functionality (including in secondary windows) and all quick-input related functions.
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers