Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ChatModel naming #14913

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Update ChatModel naming #14913

merged 1 commit into from
Feb 14, 2025

Conversation

eneufeld
Copy link
Contributor

What it does

Update the names of ChatModel implementation classes.

fixes #14872

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

sdirix
sdirix requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the same for the RequestModelImpl

@eneufeld eneufeld requested a review from sdirix February 14, 2025 08:04
sdirix
sdirix requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the chat input is broken with this PR and grows endlessly on initial load

sdirix
sdirix approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, that's already the case on the latest master. So I'll approve

@sdirix sdirix merged commit 9944d0e into eclipse-theia:master Feb 14, 2025
10 of 11 checks passed
@sdirix sdirix deleted the pr/14872 branch February 14, 2025 10:55
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

Improve chat model naming
2 participants
@eneufeld @sdirix