Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): prevent duplicate context element entries #14979

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

planger
Copy link
Contributor

@planger planger commented Feb 19, 2025

What it does

Prevents duplicate context variable requests in the AI chat input (filtering by variable and arguments).

How to test

Try adding files multiple times into the chat widget (by drag and drop, by auto-complete) and observe that it won't add it multiple times in the list.

Note that I kept adding it multiple times in the text, as users may want to use drag and drop to create the variable string for refering to it in their user request.

Follow-ups

None

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

None

Review checklist

Reminder for reviewers

@colin-grant-work
Copy link
Contributor

Changes look good to me - good to keep the context cleaner.

@planger planger merged commit 5887d65 into master Feb 19, 2025
9 of 11 checks passed
@planger planger deleted the planger/prevent-dupes-in-context branch February 19, 2025 15:43
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants