GH-1584: Fixed file search in Windows. #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM for the search-in-workspace part. |
|
I have fixed the Windows: OS X: I will check in the context of this PR, what's going on. |
|
Also, as one can see, we use the (encoded) URI segments instead of the FS path, that's why it shows |
2 tasks
|
I have opened a follow-up for the UI issues: #1591. CC: @svenefftinge |
svenefftinge
approved these changes
Apr 1, 2018
- Updated to the most recent `vscode-ripgrep` version. It fixes the `.exe` issue on Windows. - Fixed the `rootPath`. - Replaced it with a URI, so that backend can resolve it. - Enabled the search service tests. Set the failing Git ignored test to pending. - Got rid of the obsolete type definitions. Closes #1584 Signed-off-by: Akos Kitta <kittaakos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode-ripgrepversion. It fixes the.exeissue on Windows.rootPath.Closes #1584
Signed-off-by: Akos Kitta kittaakos@gmail.com