fix: ensure UNC paths are normalized correctly on Windows #16712
+44
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11997
How to test
Create a Windows network share
Create a folder structure
foo/bar, right-clickfoo→ Properties → Sharing → Share… → approve UAC → finish sharing.Start the Theia Electron example:
https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#quick-start
In Theia, go to File → Open Folder...
In the navigation panel, open Network, select your machine, open the foo share, and select the bar folder.
Click Select Folder and verify that the UNC workspace opens and functions normally, including creating, editing, and deleting files.
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers