Fixed Git history showing incorrect date (#1754) #1776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
changed the title
kittaakos
reviewed
Apr 25, 2018
There was a problem hiding this comment.
Looks great! Thank you for the fix.
Could you please sign-off your commit with: git commit --amend --signoff?
Signed-off-by: Alex Erling <alex.erling@gmail.com>
|
I signed off. I tried to push the commit again, but it said I needed to pull the branch down first. Did I do something wrong? |
|
You need to rebase then and squash the commits. Let me know if you need help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted date to show the correct time and fixed some types.
Closes #1754.