Update getting-started 'open' commands for compatibility #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/getting-started/src/browser/getting-started-widget.tsx
Outdated
Show resolved
Hide resolved
vince-fugnitto
force-pushed
the
fix-gs
branch
from
ecfe71b
to
5e591a8
Compare
|
@marechal-p I updated the PR based on your comments to include |
paul-marechal
approved these changes
Nov 8, 2018
packages/getting-started/src/browser/getting-started-widget.tsx
Outdated
Show resolved
Hide resolved
Updated the `getting-started` widget to display `Open` commands which are supported for their operating system and based on whether the browser or electron instances are running. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
fix-gs
branch
from
5e591a8
to
b9aaac9
Compare
vince-fugnitto
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
getting-startedopencommands to be compatible with different operating systems and electron/browser instances.Opencommand is displayed all browser instances.Opencommand does not display on Electron except OSX Electron instances.Open FileandOpen Folderis displayed for non-OSX Electron instances.Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com