add java-debug extension based on vscode-java-debug #3613

akosyakov · 2018-11-23T16:31:12Z

TODO:

Debugging:

HCR:

Code lenses:

akosyakov · 2018-11-29T13:19:04Z

It is ready for the review.

I've tested with: https://github.com/kasecato/vscode-javadebug-sample

kittaakos · 2018-11-30T15:03:25Z

I am reviewing it now... (I am checking the browser version only: #3693)

svenefftinge

Awesome! worked nicely for me.

kittaakos · 2018-11-30T15:27:03Z

I cannot run on Windows:

:3000/#/c:/Users/kit…s/dev/tmp-java-ws:1 Uncaught (in promise) 
{success: false, message: "Illegal char <:> at index 2: /c:/Users/kittaakos/dev/tmp-java-ws", request_seq: 2, command: "launch", body: {…}, …}
body: {error: {…}}
command: "launch"
message: "Illegal char <:> at index 2: /c:/Users/kittaakos/dev/tmp-java-ws"
request_seq: 2
seq: 2
success: false
type: "response"
__proto__: Object

kittaakos · 2018-11-30T15:27:54Z

I cannot run on Windows:

Although it is just a guess, the problem could be here: https://github.com/theia-ide/theia/pull/3613/files#diff-70a46c1aaadf49045db1097bc9e1f699R89

svenefftinge · 2018-11-30T15:34:50Z

packages/core/src/node/messaging/messaging-backend-module.ts

+        child.bind(MessagingContainer).toConstantValue(container);
+        child.bind(MessagingContribution).toSelf();
+        return child.get(MessagingContribution);
+    });


should be singleton

benoitf · 2018-11-30T15:35:09Z

.vscode/launch.json

@@ -54,7 +54,7 @@
            "name": "Launch Backend",
            "program": "${workspaceRoot}/examples/browser/src-gen/backend/main.js",
            "args": [
-                "--log-level=debug",
+                "--hostname=0.0.0.0",


hello, I don't see how this change it is related to this feature ?

it is related because I needed it to debug extensions

benoitf · 2018-11-30T15:35:15Z

configs/warnings.tslint.json

@@ -1,5 +1,6 @@
 {
  "rules": {
+    "deprecation": true,


hello, I don't see how this change it is related to this feature ?

I've deprecated some APIs and want other developers to notice it.

my point is why deprecated notice is not discussed first
and why it should be deprecated

ok, let's discuss deprecation on Tuesday

btw it is just warning, it won't break builds and so on. There is also no APIs broken in core and developers can stop using moved APIs over time.

benoitf · 2018-11-30T15:36:40Z

packages/core/src/common/message-service-protocol.ts

@@ -94,7 +91,7 @@ export class MessageClient {
     * To be implemented by an extension, e.g. by the messages extension.
     */
    showProgress(progressId: string, message: ProgressMessage, cancellationToken: CancellationToken): Promise<string | undefined> {
-        this.logger.info(message.text);
+        console.info(message.text);


all console calls are implemented by logger already, there is no need to inject Logger

benoitf · 2018-11-30T15:40:09Z

hello, why it is not in a separate repository ?
I thought all java stuff has to be moved out of main theia repository

svenefftinge · 2018-11-30T15:46:08Z

True, but we should move everything at once.

akosyakov · 2018-12-03T13:13:44Z

@benoitf @tsmaeder @tolusha I've just double checked and not found any usages of QuickPickService in the plugin extension, it is not affected at all by this PR

benoitf · 2018-12-03T13:28:04Z

@akosyakov AFAIK plug-in extension is only using MonacoQuickOpenService yes

akosyakov · 2018-12-03T13:30:32Z

@benoitf ok, it was not changed

akosyakov · 2018-12-03T13:59:38Z

@kittaakos I've addressed all your comments.

kittaakos · 2018-12-03T14:16:15Z

I've addressed all your comments.

I am OK proceeding with this. I will take care of the Windows path issue (#3709) and for the time being, I remove the debugging extensions (#3693) from the electron example.

akosyakov · 2018-12-03T14:22:36Z

@kittaakos thank you

akosyakov · 2018-12-03T15:09:58Z

@marcdumais-work CQs:

vscode-java - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18453
vscode-java-debug - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18454

marcdumais-work · 2018-12-03T15:22:17Z

@marcdumais-work CQs:

vscode-java - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18453

vscode-java-debug - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18454

The CQs looks good, thanks Anton.

We now need to wait until the Eclipse Foundation has the time to look at them. In many cases they will give "parallel IP" check-in permission, if, after a summary look, the Foundation thinks the CQ does not raise red flags. When we have that permission for both CQs, we can merge.

marcdumais-work · 2018-12-05T16:14:00Z

Update on the CQs: no longer blocking the merge of this PR:

18453: license_certified
18454: permission to merge through parallel IP process.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov changed the title ~~add java-debug extension based on vscode-java-debug~~ WIP add java-debug extension based on vscode-java-debug Nov 23, 2018

akosyakov mentioned this pull request Nov 23, 2018

Add MS Debug Adapter as a jdt.ls extension #3401

Closed

akosyakov force-pushed the ak/java_debug branch 9 times, most recently from db66fe4 to f355b4f Compare November 29, 2018 11:36

akosyakov changed the title ~~WIP add java-debug extension based on vscode-java-debug~~ add java-debug extension based on vscode-java-debug Nov 29, 2018

akosyakov requested review from svenefftinge and AlexTugarev November 29, 2018 13:16

akosyakov mentioned this pull request Nov 29, 2018

[eclipse] Track repo's move to the "eclipse" GitHub org #3182

Closed

12 tasks

akosyakov requested a review from kittaakos November 30, 2018 08:40

akosyakov force-pushed the ak/java_debug branch 2 times, most recently from 663729d to bc44d52 Compare November 30, 2018 13:13

tolusha self-requested a review November 30, 2018 14:45

svenefftinge approved these changes Nov 30, 2018

View reviewed changes

svenefftinge reviewed Nov 30, 2018

View reviewed changes

benoitf reviewed Nov 30, 2018

View reviewed changes

akosyakov force-pushed the ak/java_debug branch 3 times, most recently from fbbad1c to 47692a4 Compare December 3, 2018 13:58

tolusha approved these changes Dec 3, 2018

View reviewed changes

marcdumais-work added the CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) label Dec 3, 2018

kittaakos mentioned this pull request Dec 4, 2018

[electron] Temporary disable the debug extensions in the electron example #3716

Closed

marcdumais-work removed the CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) label Dec 5, 2018

akosyakov added 10 commits December 6, 2018 08:15

[core] allow to scope bindings per connection

9abccc5

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

bind MessageService in the connection scope on the backend

783b1bb

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

expose QuickPickService on the backend in the connection scope

a07596b

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

add java-debug extension based on vscode-java-debug

f4e17bf

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[java-debug] hot code replace

720525f

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[java-debug] handle user notifications

8cbb11e

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[debug] fix handling sources with a URI as a path

c62910d

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[java-debug] code lenses to run/debug java program

721c2f1

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

add a guard to prevent cyclic calls to DisposableCollection.dispose

586042d

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

added missing spec tests to enable coverage stats

b7b0e1b

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov force-pushed the ak/java_debug branch from 47692a4 to b7b0e1b Compare December 6, 2018 08:21

akosyakov merged commit 9fe8aa6 into master Dec 6, 2018

akosyakov deleted the ak/java_debug branch December 6, 2018 10:12

msujew mentioned this pull request Feb 6, 2023

Remove script for downloading debug adapters #12150

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add java-debug extension based on vscode-java-debug #3613

add java-debug extension based on vscode-java-debug #3613

akosyakov commented Nov 23, 2018 •

edited

Loading

akosyakov commented Nov 29, 2018

kittaakos commented Nov 30, 2018

svenefftinge left a comment

kittaakos commented Nov 30, 2018

kittaakos commented Nov 30, 2018

svenefftinge Nov 30, 2018

benoitf Nov 30, 2018

akosyakov Nov 30, 2018 •

edited

Loading

benoitf Nov 30, 2018

akosyakov Nov 30, 2018

benoitf Nov 30, 2018

akosyakov Dec 1, 2018

benoitf Nov 30, 2018

akosyakov Nov 30, 2018

benoitf commented Nov 30, 2018

svenefftinge commented Nov 30, 2018

akosyakov commented Dec 3, 2018 •

edited

Loading

benoitf commented Dec 3, 2018 •

edited

Loading

akosyakov commented Dec 3, 2018

akosyakov commented Dec 3, 2018

kittaakos commented Dec 3, 2018

akosyakov commented Dec 3, 2018

akosyakov commented Dec 3, 2018

marcdumais-work commented Dec 3, 2018

marcdumais-work commented Dec 5, 2018

add java-debug extension based on vscode-java-debug #3613

add java-debug extension based on vscode-java-debug #3613

Conversation

akosyakov commented Nov 23, 2018 • edited Loading

akosyakov commented Nov 29, 2018

kittaakos commented Nov 30, 2018

svenefftinge left a comment

Choose a reason for hiding this comment

kittaakos commented Nov 30, 2018

kittaakos commented Nov 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akosyakov Nov 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoitf commented Nov 30, 2018

svenefftinge commented Nov 30, 2018

akosyakov commented Dec 3, 2018 • edited Loading

benoitf commented Dec 3, 2018 • edited Loading

akosyakov commented Dec 3, 2018

akosyakov commented Dec 3, 2018

kittaakos commented Dec 3, 2018

akosyakov commented Dec 3, 2018

akosyakov commented Dec 3, 2018

marcdumais-work commented Dec 3, 2018

marcdumais-work commented Dec 5, 2018

akosyakov commented Nov 23, 2018 •

edited

Loading

akosyakov Nov 30, 2018 •

edited

Loading

akosyakov commented Dec 3, 2018 •

edited

Loading

benoitf commented Dec 3, 2018 •

edited

Loading