Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git commands 'stageAll', 'unstageAll', and 'discardAll' #3943

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Add git commands 'stageAll', 'unstageAll', and 'discardAll' #3943

merged 1 commit into from
Jan 8, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jan 3, 2019

  • Added the git commands stageAll, unstageAll and discardAll to the git-widget.

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves git issues related to git labels Jan 3, 2019
@vince-fugnitto vince-fugnitto changed the title Add git commands 'stageAll' and 'unstageAll' Add git commands 'stageAll', 'unstageAll', and 'discardAll` Jan 3, 2019
@vince-fugnitto vince-fugnitto changed the title Add git commands 'stageAll', 'unstageAll', and 'discardAll` Add git commands 'stageAll', 'unstageAll', and 'discardAll' Jan 3, 2019
@jbicker
Copy link
Contributor

jbicker commented Jan 4, 2019

'Stage all' and 'Unstage all' works fine so far.
'Discard all' does not work for new files. They don't get removed as expected.
Furthermore I would like it to have the buttons in the 'Changes' resp. 'Staged changes' header lines with the same hover behaviour as for single files. See VSCode.
And for 'Discard' you should use the same Icon as it is used for discarding single changes.

@akosyakov
Copy link
Member

In additional to @jbicker's comment it would be nice to add these action in the drop-down menu.

@vince-fugnitto
Copy link
Member Author

@jbicker @akosyakov
thanks guys, I'll follow what vscode has as a ui/ux experience for these commands and update the PR accordingly.

@vince-fugnitto
Copy link
Member Author

@jbicker @akosyakov
I made the necessary updates both adding the inline toolbar to the Staged Changes, Merged Changes and Changes, as well as adding the new menu items in the context menu for the git-widget. I also addressed the issue regarding the discardAll for newly created files. Please let me know if anything else is needed. @jbicker perhaps you can help in making the toolbar for the header items look better.

Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menu and 'Discard all' works well now as the buttons in the respective headers. Thanks for that!
But as I said in code comments please use just the buttons in headers that make sense for the respective context.

- Added the git commands `stageAll`, `unstageAll` and `discardAll` to the `git-widget`.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

thank you for your feedback @jbicker, I addressed your comments, please let me know if I missed anything :)

Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Works great. Thanks!
The layout of the the buttons in the headers could be improved as you already mentioned. It is not only CSS, but also a bit DOM that has to be changed. I could take look at it in a different PR.

@vince-fugnitto
Copy link
Member Author

thanks @jbicker for looking into it and providing feedback!

@akosyakov akosyakov removed their request for review January 8, 2019 06:35
@elaihau elaihau merged commit aa1079f into eclipse-theia:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants