-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git commands 'stageAll', 'unstageAll', and 'discardAll' #3943
Conversation
'Stage all' and 'Unstage all' works fine so far. |
@jbicker @akosyakov |
@jbicker @akosyakov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Menu and 'Discard all' works well now as the buttons in the respective headers. Thanks for that!
But as I said in code comments please use just the buttons in headers that make sense for the respective context.
- Added the git commands `stageAll`, `unstageAll` and `discardAll` to the `git-widget`. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
thank you for your feedback @jbicker, I addressed your comments, please let me know if I missed anything :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Works great. Thanks!
The layout of the the buttons in the headers could be improved as you already mentioned. It is not only CSS, but also a bit DOM that has to be changed. I could take look at it in a different PR.
thanks @jbicker for looking into it and providing feedback! |
stageAll
,unstageAll
anddiscardAll
to thegit-widget
.Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com