-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin] basic support of snippets #3977
Conversation
be78203
to
58da9b4
Compare
@benoitf @evidolob @svenefftinge it is ready for the review. The last commit will be removed after approval. |
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@svenefftinge yes, |
+ load snippets async Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@svenefftinge i've deprecated it I've tested without and with plugin system. TS snippets from the TS extension are available as before and bat snippets are loaded async. If no one objects i merge it when travis build is green. |
no objection on my side |
@@ -59,7 +59,7 @@ | |||
"clean": "theia clean && rimraf errorShots", | |||
"build": "theia build --mode development", | |||
"watch": "yarn build --watch", | |||
"start": "theia start", | |||
"start": "export THEIA_DEFAULT_PLUGINS=local-dir:../../plugins && theia start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it be committed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found myself doing it over and over, and thought that we can specify relative plugins location for testing purposes.
Actually, i think maybe we should add a new example that includes only plugin-ext-vscode
and its dependency, and exclude all irrelevant Theia extensions.
// cc @svenefftinge
fix #3972
fix #3976 in order to load bat built in extension for testing
In order to try: check out, build, run browser example, create bat file and use content assist.
The changes to the browser-example and bat extension will be reverted before merging.