Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] basic support of snippets #3977

Merged
merged 3 commits into from
Jan 11, 2019
Merged

[plugin] basic support of snippets #3977

merged 3 commits into from
Jan 11, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jan 8, 2019

fix #3972
fix #3976 in order to load bat built in extension for testing

vs-code-snippets

In order to try: check out, build, run browser example, create bat file and use content assist.

The changes to the browser-example and bat extension will be reverted before merging.

@akosyakov akosyakov force-pushed the GH-3972 branch 2 times, most recently from be78203 to 58da9b4 Compare January 9, 2019 11:27
@akosyakov
Copy link
Member Author

@benoitf @evidolob @svenefftinge it is ready for the review. The last commit will be removed after approval.

@akosyakov akosyakov changed the title WIP [plugin] basic support of snippets [plugin] basic support of snippets Jan 9, 2019
@akosyakov akosyakov requested a review from svenefftinge January 9, 2019 11:29
@svenefftinge
Copy link
Contributor

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

@svenefftinge yes, TextmateSnippetCompletionProvider can be deprecated

+ load snippets async

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

@svenefftinge i've deprecated it
@benoitf i've changed loading of snippets, now they are loaded async

I've tested without and with plugin system. TS snippets from the TS extension are available as before and bat snippets are loaded async. If no one objects i merge it when travis build is green.

@benoitf
Copy link
Contributor

benoitf commented Jan 10, 2019

no objection on my side

@@ -59,7 +59,7 @@
"clean": "theia clean && rimraf errorShots",
"build": "theia build --mode development",
"watch": "yarn build --watch",
"start": "theia start",
"start": "export THEIA_DEFAULT_PLUGINS=local-dir:../../plugins && theia start",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be committed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found myself doing it over and over, and thought that we can specify relative plugins location for testing purposes.

Actually, i think maybe we should add a new example that includes only plugin-ext-vscode and its dependency, and exclude all irrelevant Theia extensions.

// cc @svenefftinge

@akosyakov akosyakov merged commit a666893 into master Jan 11, 2019
@akosyakov akosyakov deleted the GH-3972 branch January 11, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin] load VS Code extensions from sources [plugin] snippets contribution are not supported
3 participants