debug auto launch #4042

akosyakov · 2019-01-14T08:44:44Z

This PR fix issues to run and debug debug-auto-launch together with debug-node VS Code extensions.

Issues:

fix [plugin] status bar message cannot be loaded from nls #3992 - tolerate missing text fo status bar items
fix Hosted plugin does not allow to debug VS Code extensions #4010 - allow to debug VS Code extensions via the plugin-hosted extension, needed it to figure out why debug-auto-launch cannot load messages properly
set up en as default locale for VS Code extension using vscode-nls
set up VSCODE_PID as THEIA_PARENT_PID to allow debug-auto-launch to detect terminals spawned by Theia
[plugin] window.terminals & window.activeTerminal API support #4024 - support terminals related APIs on window, the same reason as previous
plugin under debug should override already installed plugin #4030 - in hosted mode, allow the hosted plugin to override the installed plugin, needed during debugging node-debug via node-debug
debug adapter executable resolved against the bogus plugin path #4036 - in hosted mode, debug adapter executable were resolved against the hosted plugin, not proper one
command arguments sent from one plugin to another gets wrapped into array #4033 - command arguments were not spread properly, leading to bogus arguments

benoitf · 2019-01-14T09:01:37Z

packages/plugin-ext/src/api/plugin-api.ts

@@ -161,7 +161,11 @@ export interface CommandRegistryExt {
 }

 export interface TerminalServiceExt {
-    $terminalClosed(id: number): void;
+    $terminalCreated(id: string, name: string): void;


cc @AndrienkoAleksandr

benoitf · 2019-01-14T09:04:06Z

packages/plugin-ext/src/main/browser/terminal-main.ts


    constructor(rpc: RPCProtocol, container: interfaces.Container) {
-        this.terminalService = container.get(TerminalService);
+        this.terminals = container.get(TerminalService);


cc @AndrienkoAleksandr

benoitf · 2019-01-14T10:49:32Z

@AndrienkoAleksandr please review for terminals

akosyakov · 2019-01-15T08:34:30Z

@AndrienkoAleksandr Could you have a look?

AndrienkoAleksandr · 2019-01-15T08:37:17Z

Yes, I reviewed yesterday. Looks good, but for now I am testing your changes. When I complete I will approve it

akosyakov · 2019-01-15T08:58:08Z

@AndrienkoAleksandr yes, testing is most important :) let me know if you need help with getting debug-auto-launch extension

AndrienkoAleksandr · 2019-01-15T10:51:57Z

@akosyakov I have terminal api samples => https://github.com/eclipse/che-theia-samples/tree/ffb35d40cb3b18e5e8f4281cf6d8ff51c2689640/samples/terminal-plugin. It doesn't work with this pull request. Could You take a look?
If You need VSCode analog => it's here https://github.com/AndrienkoAleksandr/terminalApi

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

+ enable sources maps Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

…de-nls Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov · 2019-01-16T07:32:12Z

@AndrienkoAleksandr thanks for testing and VS Code extension, super helpful

I forgot to resolve terminalExt.id before on terminal creation, fixed it:
https://github.com/theia-ide/theia/pull/4042/files#diff-38c54d295fc447f2a7d521f9f373ce55R79

akosyakov requested review from benoitf and evidolob as code owners January 14, 2019 08:44

akosyakov mentioned this pull request Jan 14, 2019

make debug-auto-launch VS Code extension to display status bar items properly #4020

Closed

akosyakov requested review from tolusha and svenefftinge January 14, 2019 08:49

akosyakov force-pushed the ak/debug_auto_launch branch from 05ad391 to a14427e Compare January 14, 2019 08:56

benoitf reviewed Jan 14, 2019

View reviewed changes

akosyakov requested a review from AndrienkoAleksandr January 14, 2019 09:08

akosyakov force-pushed the ak/debug_auto_launch branch from a14427e to 0da1762 Compare January 14, 2019 09:11

tolusha approved these changes Jan 14, 2019

View reviewed changes

akosyakov added 8 commits January 16, 2019 07:29

[plugin] fix #3992: tolerate missing text fo status bar items

a21d82b

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[plugin/hosted] #4010: allow to debug VS Code extensions

b990ec3

+ enable sources maps Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[vscode] setup en as default locale for VS Code extensions using vsco…

0cdb64b

…de-nls Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[plugin] fix #4024 support terminal APIs on window

f1902c3

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[plugin] fix #4030: prefer hosted plugin over installed

d8fc440

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[plugin] fix #4036: resolve debug executable against the correct plugin

56de289

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

set up VSCODE_PID variable for VS Code extensions

26e0392

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

[plugin] fix #4033: fix spreading of command arguments

e79109e

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov force-pushed the ak/debug_auto_launch branch from 0da1762 to e79109e Compare January 16, 2019 07:29

AndrienkoAleksandr approved these changes Jan 16, 2019

View reviewed changes

benoitf approved these changes Jan 16, 2019

View reviewed changes

akosyakov merged commit e3837bb into master Jan 16, 2019

akosyakov deleted the ak/debug_auto_launch branch January 16, 2019 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

debug auto launch #4042

debug auto launch #4042

akosyakov commented Jan 14, 2019 •

edited

Loading

benoitf Jan 14, 2019

benoitf Jan 14, 2019

benoitf commented Jan 14, 2019

akosyakov commented Jan 15, 2019

AndrienkoAleksandr commented Jan 15, 2019 •

edited

Loading

akosyakov commented Jan 15, 2019

AndrienkoAleksandr commented Jan 15, 2019

akosyakov commented Jan 16, 2019

debug auto launch #4042

debug auto launch #4042

Conversation

akosyakov commented Jan 14, 2019 • edited Loading

benoitf Jan 14, 2019

Choose a reason for hiding this comment

benoitf Jan 14, 2019

Choose a reason for hiding this comment

benoitf commented Jan 14, 2019

akosyakov commented Jan 15, 2019

AndrienkoAleksandr commented Jan 15, 2019 • edited Loading

akosyakov commented Jan 15, 2019

AndrienkoAleksandr commented Jan 15, 2019

akosyakov commented Jan 16, 2019

akosyakov commented Jan 14, 2019 •

edited

Loading

AndrienkoAleksandr commented Jan 15, 2019 •

edited

Loading