-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CallHierarchyService Plugin API #3765 #4146
Conversation
Hi @vrubezhny! 'Just discovered this PR using the initially proposed Recently I've updated the protocol proposal as requested. Please have a look and align. A dev release of the TS LS implementing the updated |
Hi @AlexTugarev ! I'll take a look/ Thank you for let me notest! |
Issue #3765 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@benoitf @evidolob @AlexTugarev ping? |
microsoft/vscode-languageserver-node#420 was accepted 🎉 , so it would make sense to update. same applies to #4154 btw 😞 |
* @param service A call hierarchy provider. | ||
* @return A [disposable](#Disposable) that unregisters this provider when being disposed. | ||
*/ | ||
export function registerCallHierarchyProvider(selector: DocumentSelector, provider: CallHierarchyProvider): Disposable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it proposed api? Please move it theia.proposed.d.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should copy it from here: https://github.com/microsoft/vscode-languageserver-node/blob/51ce5233b6f97a4e2b6bee8f729205774a243140/client/src/callHierarchy.proposed.ts#L185-L234
Please don't forget a CQ. ping @theia-ide/ip-help if you need any help with it
Issue #3765
Signed-off-by: Victor Rubezhny vrubezhny@redhat.com