[plug-in] enable running of VS Code extension tests #4231
Conversation
| @@ -117,6 +118,9 @@ export class HostedPluginProcess implements ServerPluginRunner { | |||
| env.PATH = process.env.PATH; | |||
| // add HOME to env since some plug-ins need to read files from user's home dir | |||
| env.HOME = process.env.HOME; | |||
| if (argv.extensionTestsPath) { | |||
There was a problem hiding this comment.
it's not overkill to use bring yargs dependency there ?
There was a problem hiding this comment.
yargs should be always available
but I better to replace it with CliContribution that we parse args only once
|
|
||
| // Execute the runner if it follows our spec | ||
| if (testRunner && typeof testRunner.run === 'function') { | ||
| return new Promise<void>((c, e) => { |
There was a problem hiding this comment.
minor: could we use (resolve, reject) instead of (c, e) ?
| @@ -120,10 +122,13 @@ export class PluginManagerExtImpl implements PluginManagerExt, PluginManager { | |||
| if (pluginMain !== undefined) { | |||
| this.startPlugin(plugin, configStorage, pluginMain); | |||
| } else { | |||
| return Promise.reject(new Error('Unable to load the given plugin')); | |||
| console.error(`Unable to load a plugin from "${plugin.pluginPath}"`); | |||
There was a problem hiding this comment.
should the below if (his.host.loadTests) be part of else if block instead ?
There was a problem hiding this comment.
The issue here that VS Code extension contributes only to package.json and stub main property with an inexistent file or just skip it. It causes an exception and prevents loading other plugins and tests.
There was a problem hiding this comment.
ok that's not really nice to specify main to a file that does not exist :-/
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/vscode_tests
branch
from
62c51ff to
edb34af
Compare
|
@benoitf i've addressed your comments, could you have a look again please? |
fix #4226
Changes needed to run VS Code API unit tests: https://github.com/theia-
ide/theia/issues/4224#issuecomment-459752557