fix content assist in user preferences #4667
Conversation
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
|
@akosyakov I'm sorry but can you briefly explain what the content assist is and how I can test the patch ? |
If you open user preferences editor, and press ctrl + space, you should get proposals for preference names. It is not the case on master. |
thank you ! I'll test the PR now 😃 |
| @@ -67,7 +67,7 @@ export class JsonClientContribution extends BaseLanguageClientContribution { | |||
| for (const s of allConfigs) { | |||
| if (s.fileMatch) { | |||
| for (let fileMatch of s.fileMatch) { | |||
| if (fileMatch.charAt(0) !== '/' && !fileMatch.match(/\w+:\/\//)) { | |||
| if (fileMatch.charAt(0) !== '/' && !fileMatch.match(/\w+:/)) { | |||
There was a problem hiding this comment.
@svenefftinge would be fine to remove them?
There was a problem hiding this comment.
It's fine for now but might pop up again, once we use the vs code extension.
fix #4661