[filesystem] handle copying when source and target destinations are the same

[vince-fugnitto]

Fixes #4812

• Fixes an issue when calling copy from the filesystem when
  the source and target destinations are the same. Currently,
  no check is performed to verify if the paths are different
  which leads to fs-extra throwing an error.

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

[akosyakov]

@kittaakos Could you review it please?

[kittaakos]

@vince-fugnitto, test this, please.

I think it would be better to throw an error, instead of silently return with the source.

$ touch foo.txt
$ cp foo.txt foo.txt 
cp: foo.txt and foo.txt are identical (not copied).

Thoughts?

[vince-fugnitto]

I think it would be better to throw an error, instead of silently return with the source.

Sure, I can throw an error instead!

[akosyakov]

I think it would be better to throw an error, instead of silently return with the source.

We would need to check that all clients expect it and handle properly. Do you expect that client should do something special with such error or they would just ignore? If ignore maybe return silently is not a bad option, less code for clients or errors in logs.

[vince-fugnitto]

I think it would be better to throw an error, instead of silently return with the source.

We would need to check that all clients expect it and handle properly. Do you expect that client should do something special with such error or they would just ignore? If ignore maybe return silently is not a bad option, less code for clients or errors in logs.

I was thinking silent would be enough since the error would most likely be ignored.
Copying a file to itself won't do anything anyways, so there's really no need to perform extra handling on each client. I returned the sourceStat since we can assume the copy was successful to
itself (does nothing)

[kittaakos]

e enough since the error would most likely be ignored.

That's my problem, if you are copying something to the same destination, then something was already wrong. So I want to see an error, instead of ignoring it.

[vince-fugnitto]

@kittaakos updated!

[kittaakos]

@kittaakos updated!

Please add a test.

[vince-fugnitto]

@kittaakos updated!

Please add a test.

Done!

[vince-fugnitto]

@kittaakos are you fine with the latest changes?

[kittaakos]

It works as expected; thank you for the patch! 👍

[vince-fugnitto]

thank you @kittaakos !