Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4986: Added special rule for IntlBackslash key on Mac #4999

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Conversation

spoenemann
Copy link
Contributor

@spoenemann spoenemann commented Apr 25, 2019

Fixes #4986.
The IntlBackslash key is handled differently depending on the keyboard layout: On Windows it usually maps to \, while on Mac it maps to `.

Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
@spoenemann spoenemann requested a review from AlexTugarev April 25, 2019 10:12
@spoenemann
Copy link
Contributor Author

Possibly related:
microsoft/vscode#24153
microsoft/vscode#69745

@spoenemann
Copy link
Contributor Author

A very similar fix has been made in VS Code:
microsoft/vscode@2865949#diff-2ec5406e5de9e81cb5e41b6024340c2d

But later it has been removed:
microsoft/vscode@3a03183#diff-2ec5406e5de9e81cb5e41b6024340c2d

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spoenemann! That works nicely for me with Chrome and Safari on OSX :-)

2019-04-25 16 47 35

I haven't tested with German layout, did you?

@akosyakov
Copy link
Member

@AlexTugarev regarding German: #4986 (comment) so it does not work, but it is the same in VS Code

@spoenemann
Copy link
Contributor Author

I'm not 100% sure this doesn't cause problems with other keyboard layouts on Mac, but let's take it as a start.

@spoenemann spoenemann merged commit 6366cda into master Apr 26, 2019
@spoenemann spoenemann deleted the GH-4986-2 branch April 26, 2019 06:40
@beck
Copy link

beck commented Jul 2, 2019

Also experiencing on vscode@1.35.1 on osx@10.14.5 - no special keyboard.

Adding this to keybinding.json is an uncomfortable band-aid:

  {
    "key": "cmd+`",
    "command": "workbench.action.quickSwitchWindow"
  },

@spoenemann
Copy link
Contributor Author

The fix has been reimplemented in #5063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keybinding] Support international/US layout
4 participants